Skip to content

chore: document GitHub issues flow #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexkrolick
Copy link
Collaborator

What:

  • Documents GitHub flows for bugs and feature requests
  • Recommends communities for asking questions instead of filing issues

Why:

https://twitter.com/samselikoff/status/991395669016436736

One difference I'm proposing is not closing new feature requests to make it easier to use the GitHub UI to sort/filter/browse open requests. But closing issues and adding a "votes needed" is a valid idea, too.

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@alexkrolick alexkrolick force-pushed the gh-issues-organization branch from 536a1a4 to 1c81066 Compare May 2, 2018 04:29
kentcdodds
kentcdodds previously approved these changes May 2, 2018
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Do you think you could also update .github/ISSUE_TEMPLATE.md to help set expectations as well? I think people will probably be surprised when we close their issue, so it'd probably be helpful to include a note in the template.

Thanks!

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we just copy the policies right in the template. Much more likely that folks will read it.

@kentcdodds
Copy link
Member

I set up a community on spectrum. Why don't we add a badge at the top. Probably the last badge on the 2nd line of badges:

Join the community on Spectrum

[![Join the community on Spectrum](https://withspectrum.github.io/badge/badge.svg)](https://spectrum.chat/react-testing-lib)

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo!

@kentcdodds kentcdodds merged commit 46c3a7e into testing-library:master May 2, 2018
@alexkrolick alexkrolick deleted the gh-issues-organization branch May 2, 2018 20:42
@kentcdodds
Copy link
Member

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

julienw pushed a commit to julienw/react-testing-library that referenced this pull request Dec 20, 2018
…ing-library#67)

* feat(queries): allow overriding queries in getQueriesForElement

* feat(queries): remove array option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants